Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI configs to v0.1.0 #49

Closed
wants to merge 1 commit into from
Closed

Update CI configs to v0.1.0 #49

wants to merge 1 commit into from

Conversation

pionbot
Copy link
Contributor

@pionbot pionbot commented Jan 13, 2020

Update lint scripts and CI configs.

Update lint scripts and CI configs.
@at-wat
Copy link
Member

at-wat commented Jan 13, 2020

$ bash .github/lint-disallowed-functions-in-library.sh
/home/travis/gopath/src/github.com/pion/transport/.github/../test/util.go:		panic("timeout")
panic( may only be used in example code
The command "bash .github/lint-disallowed-functions-in-library.sh" exited with 1.

// nolint should be added.

@at-wat
Copy link
Member

at-wat commented Jan 13, 2020

--- FAIL: TestNetNative (0.01s)
    --- PASS: TestNetNative/Interfaces (0.00s)
    --- FAIL: TestNetNative/ResolveUDPAddr (0.00s)
        net_native_test.go:46: 
            	Error Trace:	net_native_test.go:46
            	Error:      	Not equal: 
            	            	expected: "127.0.0.1"
            	            	actual  : "127.0.1.1"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-127.0.0.1
            	            	+127.0.1.1
            	Test:       	TestNetNative/ResolveUDPAddr
            	Messages:   	should match

The test code seems environment dependent.

@at-wat at-wat mentioned this pull request Jan 13, 2020
@at-wat at-wat closed this Jan 13, 2020
@at-wat at-wat deleted the sync-assets-v0.1.0 branch January 13, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants