-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adapt samplebuilder new depacketizer in pion/rtp
Both partition head and tail checking is now done in the depacketizer. For backwards compatibility, there are stubs for PartitionHeadChecker and WithPartitionHeadChecker that do nothing; these should be removed for 4.0. This also fixes a bug with the depacketizer: if no head checker was present, every packet would be considered as a potential partition head, even if it was at the beginning of the buffer. Since a partition head checker is now always present, the bug cannot happen. The tests assume the old bug, which is why the fakePacketizer returns true if headBytes is empty. It would be better to adapt the tests to do the right thing, as in jech/depacketizer.
- Loading branch information
Showing
4 changed files
with
36 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters