Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty ID and StreamID when simulcasting #1808

Closed
jech opened this issue May 12, 2021 · 3 comments · Fixed by #1930
Closed

Empty ID and StreamID when simulcasting #1808

jech opened this issue May 12, 2021 · 3 comments · Fixed by #1930

Comments

@jech
Copy link
Contributor

jech commented May 12, 2021

Browser is offerer, and offers a PC with a single sendonly transceiver with two simulcast tracks. When Pion fires OnTrack, both track.StreamID() and track.ID() are empty.

This does not happen if either of the following is true:

  • there is an audio track in the same PC in addition to the simulcast transceiver;
  • the client is not sending a simulcast track.

The offer sent by the browser is correct as far as I can see (it contains a well-formed a=msid line in the simulcast m section).
@zyxar
Copy link
Member

zyxar commented May 12, 2021

I think I've seen similar cases (null ids) in our project. However we avoided using theses IDs directly in logic.

@jech jech mentioned this issue May 14, 2021
Open
19 tasks
@Sean-Der Sean-Der added this to the 3.1.0 milestone Aug 1, 2021
@Sean-Der
Copy link
Member

Found the issue! Should have a fix soon.

libwebrtc is able to handle a SetRemoteDescription with one media section and no SSRC. We added similar code here

So we have two things to fix here.

  • We should populate StreamID/ID for non-SSRC single media sections
  • We should assert that the MediaSection doesn't have a RID/Simulcast

Sean-Der added a commit that referenced this issue Aug 23, 2021
@Sean-Der
Populate ID/StreamID for Undeclared SSRC
b03856c 
Relates to #1808
Sean-Der added a commit that referenced this issue Aug 24, 2021
@Sean-Der
Don't consider simulcast for undeclared SSRC
fb36341 
If we have a media section with no SSRC we would fire an OnTrack. This
code now properly ignores a MediaSection that has a rid attribute.

Resolves #1808
@Sean-Der Sean-Der mentioned this issue Aug 24, 2021
Merged
pionbot pushed a commit that referenced this issue Aug 24, 2021
@Sean-Der
Don't consider simulcast for undeclared SSRC
fe8622b 
If we have a media section with no SSRC we would fire an OnTrack. This
code now properly ignores a MediaSection that has a rid attribute.

Resolves #1808
Sean-Der added a commit that referenced this issue Aug 24, 2021
@Sean-Der
Don't consider simulcast for undeclared SSRC
89042ee 
If we have a media section with no SSRC we would fire an OnTrack. This
code now properly ignores a MediaSection that has a rid attribute.

Resolves #1808
@jech
Copy link
Contributor Author

jech commented Aug 25, 2021

Confirmed, thanks for the fix.

daonb pushed a commit to daonb/webrtc that referenced this issue Nov 20, 2022
@Sean-Der @daonb
Populate ID/StreamID for Undeclared SSRC
d15e027 
Relates to pion#1808
daonb pushed a commit to daonb/webrtc that referenced this issue Nov 20, 2022
@Sean-Der @daonb
Don't consider simulcast for undeclared SSRC
a594959 
If we have a media section with no SSRC we would fire an OnTrack. This
code now properly ignores a MediaSection that has a rid attribute.

Resolves pion#1808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't consider simulcast for undeclared SSRC pion/webrtc
3 participants
@jech @zyxar @Sean-Der