Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add drawio files for examples #1998

Closed
mohammadne opened this issue Oct 28, 2021 · 2 comments
Closed

add drawio files for examples #1998

mohammadne opened this issue Oct 28, 2021 · 2 comments

Comments

@mohammadne
Copy link
Contributor

mohammadne commented Oct 28, 2021

HI @Sean-Der

Summary

adding drawio diagrams for examples

Motivation

it's very useful for better and one-look understanding of examples

Additional context

I'm willing to add this feature for all the examples,
please let me know about that and I will create pull-request for them

in order to not increase project size, I only add drawio xml files (each one is text-based and is about 2Kb) and I'm not include rendered files (png, ...).

Thanks :)

@mohammadne
Copy link
Contributor Author

Hi @Sean-Der

is there any update about status of the issue ?
I have submitted a pull-request

@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
@Sean-Der
Copy link
Member

Hi @mohammadne

I really regret that this didn't get in. It was my fault that I didn't do a better job of guiding this PR. I am going to work on this.

Since this PR had started Github added mermaidjs. I started porting to mermaidjs here. I put you as the author.

I started with data-channel, but I am planning on doing them all #2415. I understand if you are burned out/not interested in working on Pion (you didn't have a great experience). I would love to have you involved on this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants