-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add drawio diagram for examples #1999
Conversation
@mohammadne fantastic work! I would love to add these. Could you also put the image in the README themselves? A few changes
|
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
==========================================
- Coverage 77.19% 76.64% -0.56%
==========================================
Files 84 85 +1
Lines 8783 6225 -2558
==========================================
- Hits 6780 4771 -2009
+ Misses 1593 1045 -548
+ Partials 410 409 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yes, for sure |
Hi @Sean-Der I just updated the pull-request to include your requested feature. Thanks alot :) |
HI @Sean-Der can you please check it! |
the only remaining diagram is for thanks for your awesome library 💯 |
Fantastic work @mohammadne ! Thank you so much for contribution to Pion :) I will review and merge first thing tomorrow. I think this will help people a lot. |
Hi @Sean-Der |
HI @Sean-Der |
Hi @mohammadne I really regret that this didn't get in. It was my fault that I didn't do a better job of guiding this PR. I am going to work on this. Since this PR had started Github added mermaidjs. I started porting to mermaidjs here. I put you as the author. I started with data-channel, but I am planning on doing them all #2415. I understand if you are burned out/not interested in working on Pion (you didn't have a great experience). I would love to have you involved on this though! |
progress
notes
architecture
link to view online schema of the diagramReference issue