Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to RTCPeerConnection #222

Closed
aguilEA opened this issue Nov 9, 2018 · 1 comment
Closed

Add logging to RTCPeerConnection #222

aguilEA opened this issue Nov 9, 2018 · 1 comment

Comments

@aguilEA
Copy link
Contributor

aguilEA commented Nov 9, 2018

RTCPeerConnection should have a logger to debug SDP/Packets and to log other messages at varying verbose levels. RTCPeerConnection should accept an interface so that a user can customize a logger and pass the logger to RTCPeerConnection through a setter. This logging implementation can begin with a simple default logger that will replace all the fmt.print and fmt.printf messages that are currently in rtcpeerconnection.go.

aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 9, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 10, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 10, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 10, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 10, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 14, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 19, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 19, 2018
Resolves pion#222

Implemen# Please enter the commit message for your changes. Lines starting
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 19, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 19, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 19, 2018
aguilEA added a commit to aguilEA/webrtc that referenced this issue Nov 25, 2018
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 27, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 27, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 27, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g. PIONS_LOG_TRACE=ice PIONS_LOG_INFO=all

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 28, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Dec 30, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
mjmac added a commit that referenced this issue Dec 30, 2018
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to #222
mjmac added a commit to mjmac/webrtc that referenced this issue Jan 16, 2019
Convenience function for printing the log level
as a string.

Relates to pion#222
mjmac added a commit to mjmac/webrtc that referenced this issue Jan 16, 2019
These messages should be at Trace level or removed altogether.

Relates to pion#222
backkem pushed a commit that referenced this issue Jan 16, 2019
Convenience function for printing the log level
as a string.

Relates to #222
backkem pushed a commit that referenced this issue Jan 16, 2019
These messages should be at Trace level or removed altogether.

Relates to #222
@backkem
Copy link
Member

backkem commented Jan 23, 2019

Basic logging support has been added in #360.

@backkem backkem closed this as completed Jan 23, 2019
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
Allow package-scoped logging at user-defined levels. Logs are at
ERROR by default, for critical errors which should be handled
by users.

More verbose logging may be enabled via combinations of environment
variables, e.g.
PIONS_LOG_TRACE=ice PIONS_LOG_DEBUG=pc,dtls PIONS_LOG_INFO=all <cmd>

Relates to pion#222
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
Convenience function for printing the log level
as a string.

Relates to pion#222
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
These messages should be at Trace level or removed altogether.

Relates to pion#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants