Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full ICE #23

Closed
Sean-Der opened this issue Jul 4, 2018 · 6 comments
Closed

Implement full ICE #23

Sean-Der opened this issue Jul 4, 2018 · 6 comments
Assignees

Comments

@Sean-Der
Copy link
Member

Sean-Der commented Jul 4, 2018

Currently we only implement ice-lite we need to finish this so we can operate with other peers that are ice-lite only.

  • We should be able to respond to DTLS handshakes (currently we always generate them)
  • We should generate the STUN requests to check for ICE connectivity (instead of only responding to them)
  • Accept the first connected peer

The full RFC is here you don't have to implement it fully, just enough so we have an MVP. Then we can keep improving it. It is a big RFC

@chenkaiC4
Copy link
Contributor

Hi, @Sean-Der , i'm read ICE draft, and want to try solve this issue. I will give a PR as soon as possiple.

@Sean-Der
Copy link
Member Author

Sean-Der commented Jul 5, 2018

@chenkaiC4 That would be fantastic!

I am also on Slack so anytime you want to chat I am available. This will be great when we get the Wiki started also. I am setting some stuff up but will also add it so you can create branches on this repo, I want everyone to be able to push/work on code together.

Hopefully great less friction, and make it more enjoyable to contribute :)

@chenkaiC4
Copy link
Contributor

@Sean-Der thanks, 🥂

@Sean-Der
Copy link
Member Author

Hey @chenkaiC4 now that DataChannels dropped I have time to work on this!

If you started working already I would love to work together on it. If you haven't had time no worries at all I have time to grab it now :)

@chenkaiC4
Copy link
Contributor

@Sean-Der sorry, last month i spend most time on api work of company, and today finally reach a release. i have see the branch for ice, i will try to work together with you on it.

Sean-Der added a commit that referenced this issue Aug 11, 2018
Sean-Der added a commit that referenced this issue Aug 11, 2018
@Sean-Der
Copy link
Member Author

@chenkaiC4 no worries at all!

When ever you are ready to contribute would love to have you, we are all on Slack also if you ever need help finding a good issue.


This was implemented by #56

Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants