Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set role when actpass remote to DTLSRoleClient #1258

Merged
merged 1 commit into from Jun 16, 2020
Merged

Set role when actpass remote to DTLSRoleClient #1258

merged 1 commit into from Jun 16, 2020

Conversation

Sean-Der
Copy link
Member

This matches rfc5763, setup:active is RECOMMENDED

Relates to #494

@Sean-Der Sean-Der requested review from jeremija and at-wat June 16, 2020 05:52
This matches rfc5763, setup:active is RECOMMENDED

Relates to #494
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #1258 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
+ Coverage   76.28%   76.62%   +0.33%     
==========================================
  Files          70       70              
  Lines        5334     5334              
==========================================
+ Hits         4069     4087      +18     
+ Misses        941      928      -13     
+ Partials      324      319       -5     
Flag Coverage Δ
#go 79.00% <100.00%> (+0.38%) ⬆️
#wasm 69.70% <ø> (ø)
Impacted Files Coverage Δ
dtlsrole.go 100.00% <ø> (ø)
dtlstransport.go 70.09% <100.00%> (+1.40%) ⬆️
peerconnection.go 77.64% <0.00%> (+0.19%) ⬆️
icetransport.go 74.82% <0.00%> (+1.39%) ⬆️
sctptransport.go 81.12% <0.00%> (+3.57%) ⬆️
internal/mux/mux.go 90.76% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1bc16...eff5d6c. Read the comment docs.

@Sean-Der Sean-Der merged commit cc8d801 into master Jun 16, 2020
@Sean-Der Sean-Der deleted the issue-494 branch June 16, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants