-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TrackLocalContext an interface #2170
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
==========================================
- Coverage 79.42% 77.72% -1.71%
==========================================
Files 76 87 +11
Lines 8477 9374 +897
==========================================
+ Hits 6733 7286 +553
- Misses 1359 1657 +298
- Partials 385 431 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
That's pretty interesting @kevmo314 ! Are you calling |
Switching it from a struct to a pointer technically is API breakage Let me check |
I think because all the properties are private it shouldn't cause any breakages but I'll hold off, let me know when you're comfortable merging :) I'm calling |
I tested This could have negative effects on users using reflection. I hope that this doesn't effect anyone. If it does reach out and happy to undo! thanks |
This allows external users to provide their own TrackLocalContext to be bound to a track.
I second this change, but I believe we should migrate versioning rule to semver someday (bump MAJOR version when making incompatible API changes) |
This allows external users to provide their own TrackLocalContext to be
bound to a track.