Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicate stats from marshall test #2451

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Drop duplicate stats from marshall test #2451

merged 1 commit into from
Apr 11, 2023

Conversation

tmatth
Copy link
Contributor

@tmatth tmatth commented Apr 7, 2023

SenderAudioTrackAttachmentStats and VideoReceiverStats were repeated.

@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (308f861) 77.79% compared to head (3435f2d) 77.75%.

❗ Current head 3435f2d differs from pull request most recent head 03379f4. Consider uploading reports for the commit 03379f4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage   77.79%   77.75%   -0.04%     
==========================================
  Files          87       87              
  Lines        9308     9307       -1     
==========================================
- Hits         7241     7237       -4     
  Misses       1642     1642              
- Partials      425      428       +3
Flag Coverage Δ
go 79.54% <ø> (-0.04%) ⬇️
wasm 70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sean-Der Sean-Der force-pushed the stat-test/cleanup branch 2 times, most recently from 57e8f24 to d90d147 Compare April 7, 2023 19:45
tmatth
tmatth commented Apr 7, 2023
View reviewed changes
AUTHORS.txt Outdated
@@ -188,6 +188,8 @@ Thomas Miller <tmiv74@gmail.com>
Tobias Fridén <tobias.friden@gmail.com>
Tomek <tomek@pop-os.localdomain>
treyhakanson <treyhakanson@gmail.com>
Tristan <tmatth@videolan.org>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the bot is insisting on adding this...

@tmatth tmatth requested a review from edaniels April 8, 2023 17:39
edaniels
edaniels approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edaniels
Copy link
Member

edaniels commented Apr 8, 2023

May need to do a lint pass and then we can merge

@edaniels edaniels merged commit 303f204 into master Apr 11, 2023
@edaniels edaniels deleted the stat-test/cleanup branch April 11, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edaniels edaniels edaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmatth @edaniels