Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI configs to v0.10.7 #2456

Merged
merged 2 commits into from
May 5, 2023
Merged

Update CI configs to v0.10.7 #2456

merged 2 commits into from
May 5, 2023

Conversation

pionbot
Copy link
Contributor

@pionbot pionbot commented Apr 18, 2023

Update lint scripts and CI configs.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f74821) 77.83% compared to head (0cb472b) 77.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2456   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files          87       87           
  Lines        9319     9319           
=======================================
  Hits         7253     7253           
  Misses       1639     1639           
  Partials      427      427           
Flag Coverage Δ
go 79.62% <ø> (ø)
wasm 70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api.go 100.00% <ø> (ø)
api_js.go 100.00% <ø> (ø)
atomicbool.go 100.00% <ø> (ø)
bundlepolicy.go 89.65% <ø> (ø)
certificate.go 66.23% <ø> (ø)
configuration_common.go 100.00% <ø> (ø)
constants.go 100.00% <ø> (ø)
datachannel.go 87.27% <ø> (ø)
datachannel_js.go 42.19% <ø> (ø)
datachannel_js_detach.go 0.00% <ø> (ø)
... and 76 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sean-Der
Copy link
Member

@stv0g What should we do about the new licensing lint? Do you know of any tooling that could auto append the license to every file?

I can write a bash script that can do that, and we can split the repos!

@stv0g
Copy link
Member

stv0g commented Apr 25, 2023

Hi @Sean-Der,

What should we do about the new licensing lint?

I've started adding the license headers to most of the ICE/STUN/TURN related repos with the following command:

find . -name "*.go" -exec sed -i '1i // SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>\n// SPDX-License-Identifier: MIT\n' {} \;

But in the end, I think we manually need to check each file anyway.

There is also a local CLI command to test the REUSE compliance which I use to download licenses and check the headers: https://github.com/fsfe/reuse-tool

pionbot and others added 2 commits May 5, 2023 16:55
@Sean-Der Sean-Der merged commit 683fc83 into master May 5, 2023
19 checks passed
@Sean-Der Sean-Der deleted the sync-assets-v0.10.7 branch May 5, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants