Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: glitch due to comment on the documentation #2489

Merged
merged 1 commit into from
May 22, 2023

Conversation

KunalSin9h
Copy link
Contributor

Reference issue

Fixes #2448

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (323469d) 77.72% compared to head (09cb809) 77.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2489      +/-   ##
==========================================
+ Coverage   77.72%   77.80%   +0.08%     
==========================================
  Files          87       87              
  Lines        9324     9324              
==========================================
+ Hits         7247     7255       +8     
+ Misses       1647     1642       -5     
+ Partials      430      427       -3     
Flag Coverage Δ
go 79.60% <100.00%> (+0.09%) ⬆️
wasm 70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
peerconnection.go 78.56% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sean-Der
Copy link
Member

Great work! Thank you @KunalSin9h

@Sean-Der Sean-Der merged commit 1df634e into pion:master May 22, 2023
18 checks passed
@KunalSin9h KunalSin9h deleted the fix-doc branch May 23, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation glitch with nolint
2 participants