dtlstransport: Add ExtendedMasterSecret, ClientCAs, RootCAs, ClientAuth #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonVerkada LGTM! When CI passes I will merge and tag |
|
If you are interested in getting involved with Pion would love to have you involved. Also any feedback about what we could improve? Thank you! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
- Coverage 77.75% 77.65% -0.11%
==========================================
Files 87 87
Lines 9324 9340 +16
==========================================
+ Hits 7250 7253 +3
- Misses 1645 1657 +12
- Partials 429 430 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
SimonVerkada
force-pushed
the
simon/dtlstransport-ca
branch
from
70baba8
to
6f59ea3
Compare
SimonVerkada
force-pushed
the
simon/dtlstransport-ca
branch
from
6f59ea3
to
5234db6
Compare
Sean-Der
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add the following options to the
SettingsEngine, in order to allow connections to verify certificates:disableInsecureSkipVerify: disables the insecure skip verify flag for DTLS.extendedMasterSecret: sets the extended master secret type for DTLS.clientAuth: sets the client auth type for DTLS.clientCAs: sets the client CA certificate pool for DTLS certificate verification.rootCAs: sets the root CA certificate pool for DTLS certificate verification.Reference issue
None