Add RTOMax settings #2682
Closed
Add RTOMax settings #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowing the user to cap the retranmission timeout, this change adds RTOMax to SettingEngine and pass it on when creating an sctp Client
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2682 +/- ##
===========================================
- Coverage 77.15% 64.54% -12.62%
===========================================
Files 87 64 -23
Lines 9752 3689 -6063
===========================================
- Hits 7524 2381 -5143
+ Misses 1770 1180 -590
+ Partials 458 128 -330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry this took so long @daonb merging now! |
|
Cherry-picked with fb82fff I had to fix a small conflict in settingengine.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For this to work, you'll need pion/sctp#303 to get sctp level support for configurable rtoMAX
Adding RTOMax to SettingEngine and passing it on when creating an sctp Client. This will allow low-bandwidth time critical apps to limit the retransmission timeout and better perform under congestion.
Reference issue
pion/sctp#181