Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whip/whep example #2708

Merged
merged 1 commit into from
Mar 25, 2024
Merged

whip/whep example #2708

merged 1 commit into from
Mar 25, 2024

Conversation

stephanrotolante
Copy link
Contributor

@stephanrotolante stephanrotolante commented Mar 20, 2024

Description

Small example of a WHIP/WHEP exchange

Reference issue

resolves #2499

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (836184c) to head (923541c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   76.40%   76.36%   -0.05%     
==========================================
  Files          87       87              
  Lines        9923     9923              
==========================================
- Hits         7582     7578       -4     
- Misses       1870     1873       +3     
- Partials      471      472       +1     
Flag Coverage Δ
go 77.89% <ø> (-0.05%) ⬇️
wasm 64.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanrotolante
Copy link
Contributor Author

@Sean-Der Let me know if you'd like to see more implemented.

There a a few more status codes and http verbs as part of a full WHIP/WHEP implementation

Copy link
Contributor

@daonb daonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephan! The code looks clean and simple.

examples/whip-whep/main.go Outdated Show resolved Hide resolved
examples/whip-whep/main.go Outdated Show resolved Hide resolved
examples/whip-whep/main.go Outdated Show resolved Hide resolved
@Sean-Der
Copy link
Member

Great work @stephanrotolante ! We should be able to merge this super quick

Instead of FFMPEG can we do a flow with OBS? The newest version has WHIP support and is what people want to build with.

I think the goal is publish once with OBS then watch unlimited times.

@stephanrotolante stephanrotolante force-pushed the whip-whep-demo branch 2 times, most recently from 730ca75 to 3a2d060 Compare March 21, 2024 04:20
@stephanrotolante stephanrotolante changed the title initial work for whip/whep example whip/whep example Mar 21, 2024
@Sean-Der Sean-Der force-pushed the whip-whep-demo branch 3 times, most recently from 616bc64 to da3e0c5 Compare March 24, 2024 02:26
@Sean-Der
Copy link
Member

@stephanrotolante I made some changes, mind checking them out?

I put WHIP and WHEP in the same example. I was able to publish via OBS, and then pull back the same feed via WHEP.

http://localhost:8080/whip

and

http://localhost:8080/whep

Since your name is on the commit mind trying out and make sure you like it/agree with how it all flows? I am going to update the docs tomorrow and merge!

@stephanrotolante
Copy link
Contributor Author

@stephanrotolante I made some changes, mind checking them out?

I put WHIP and WHEP in the same example. I was able to publish via OBS, and then pull back the same feed via WHEP.

http://localhost:8080/whip

and

http://localhost:8080/whep

Since your name is on the commit mind trying out and make sure you like it/agree with how it all flows? I am going to update the docs tomorrow and merge!

Looks good to me!

@stephanrotolante
Copy link
Contributor Author

stephanrotolante commented Mar 25, 2024

@Sean-Der with my readme I added a video (there is no audio), walking through how to use OBS with a WHEP source. You might want to delete that since the api was changed up.

It looks like I got WHEP + WHIP mixed up

Create WHIP/WHEP example works with OBS or browser

Resolves pion#2499
@Sean-Der Sean-Der merged commit a8c02b0 into pion:master Mar 25, 2024
16 checks passed
@Sean-Der
Copy link
Member

@stephanrotolante Done! Merged into master, great work :)

Give it a try and I am sure I made mistakes, please send PRs and will merge them quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: using WHIP and WHEP
3 participants