Econ trade.lua

[radius75]

Issue #2648

[lwho]

I agree with the calculation change. I was already wondering about the strange changes when loading/unloading cargo.

As for the label: In my understanding cargo space is the room where cargo is stored and so includes both the empty and occupied area. The gauge describes how much of each is there (so describes the complete cargo space). So, I would leave the label as it is.
But I'm not a native speaker of English, and you aren't either, I think? So we should wait for one to comment on this.

Technical comment in case the text should be changed: This is the only place where the CARGO_SPACE string is used, so I think you should either just change the message or remove the now unused CARGO_SPACE (I think, I would prefer just changing the message).

[robn]

Its supposed to show used/total, and be read eg "5 used of 10". This construction is fairly common in English eg game scores or school grades are often "4 out of 5" or similar.

I suppose free space remaining is probably a more useful figure, as long as its clear to the reader. I wonder if we should just be really explicit, something like:

(Just a mockup, so ignore the fact that the gauge doesn't match the numbers!)

[robn]

I implemented this on robn/cargo-counts.

What do you think?

[nozmajner]

I like it. Playing with text size is very useful, and adds a lot in general if done good. And this one looks good.
Is it hard to use more than one font in those screens? The Titillium has some very nice weights.

[radius75]

This is good solution

[robn]

@nozmajner not hard to add extra fonts, its just a case of how to refer to them. I've tried to make the whole UI not pegged to any particular font, so the two fonts are just "normal" and "heading", and are hooked up to actual font tiles in the data files in data/fonts. But yes, we should think about it.

@radius75 looks good. I'll pull it all together and merge it right now.

[robn]

Fyi I'm intending soon (its mostly done) to include the station view footer on the info view, so this cargo screen will get a cleanup then too.