Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ECM particles in the correct location #3087

Merged
merged 1 commit into from
Jul 27, 2014

Conversation

johnbartholomew
Copy link
Contributor

Fixes #3082.

Previously the renderer's model-view transform was not being set before drawing the ECM point sprites, so it just used whatever model-view transform was set by previous semi-unrelated code. Since the ship model is rendered right before the ECM particles, the previously set transform was nearly correct, but could include some offset matching some part of the model (e.g., the most recently rendered navigation light).

@walterar
Copy link
Contributor

This works fine now. But it should be possible to activate ECM in lua. NPCs are completely unprotected against a missile.

@johnbartholomew johnbartholomew merged commit 39e5b96 into pioneerspacesim:master Jul 27, 2014
@johnbartholomew johnbartholomew deleted the issue-3082 branch July 27, 2014 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECM blast misplaced
2 participants