Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when player explodes in-dock. #3710

Merged
merged 1 commit into from
May 25, 2016
Merged

Fix crash when player explodes in-dock. #3710

merged 1 commit into from
May 25, 2016

Conversation

fluffyfreak
Copy link
Contributor

Remove bogus assert, it is not necessary to check that the player is alive.
This fixes #2116

@fluffyfreak fluffyfreak self-assigned this May 25, 2016
@laarmen
Copy link
Contributor

laarmen commented May 25, 2016

Why is it not necessary?

@fluffyfreak
Copy link
Contributor Author

fluffyfreak commented May 25, 2016 •
edited
Loading

Remove it and everything behaves as expected, there's no crash, nothing depends on the player being alive.
You do need a valid player pointer, but we have that so it's fine.

@laarmen
Copy link
Contributor

laarmen commented May 25, 2016

👍

@fluffyfreak fluffyfreak merged commit ce4f3dc into pioneerspacesim:master May 25, 2016
@fluffyfreak fluffyfreak deleted the fix2116 branch May 25, 2016 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fluffyfreak fluffyfreak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion `!Pi::player->IsDead()' failed.
2 participants
@fluffyfreak @laarmen