Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time accel +- shortcuts sometimes jump more than one step. #3875

Closed
nozmajner opened this issue Nov 22, 2016 · 7 comments
Closed

Time accel +- shortcuts sometimes jump more than one step. #3875

nozmajner opened this issue Nov 22, 2016 · 7 comments

Comments

@nozmajner
Copy link
Contributor

nozmajner commented Nov 22, 2016

Observed behaviour

I noticed that the time acceleration step increase and decrease keyboard shortcuts sometimes jumps more than one step. Sometimes right to the top level even, and it happens up and down: if it jumps up two steps, then it also jumps down two steps.

Expected behaviour

Buttons only increase/decrease one step.

Steps to reproduce

It happens both on current master and the latest 2016-1110 (win32).
Start a new game, the shortcuts work as expected.
Exit to main menu and start a new game on any of the starting points, or load a save.
Now it increases/decreases 2x
Go to main menu and start another game
Now it's 3x jump
Another new start
Now it's 4x jump
...
It goes away if you quit the game and restart, both for new games or loaded saves.

(I noticed this a while ago, but I don't know how to reproduce it reliably apart from playing for a while. I'll record it next time I encounter it, I'm just reporting it, so I won't forget about it. (Or even better, somebody can reproduce it)
It usually happens after a bit of flying around. I notice it mostly when higher levels are restricted (close to a planet), and from 1x it jumps right away to 100x or above, skipping 10x, and they just blink away, and don't really accelerate time.
Just tried to get it again, but it didn't want to show it's face, even after forcing restricted levels by selecting it with ctrl, or landing and taking off again.
)

My pioneer version (and OS):
Latest master, also happened on 20161028 win32
Win7 64 bit
It happens on 2015-1221, the first build on the moddb page that has it.

@walterar
Copy link
Contributor

walterar commented Nov 23, 2016

This is another symptom of the same old bug that produces #3345 and #3733
If you close and reopen the saved game (sometimes many times) it returns to normal.

Fixing this bug should be top priority. Pioneer does not retrieve the saved game exactly.

@nozmajner
Copy link
Contributor Author

@walterar You are right and helped me figuring it out, but you are wrong about the cause. It does happen after a reload, but it's unrelated to the alert level. I don't get the alert bug, but it still happens.
And it happens also if you exit to the main menu and start a new game.

@walterar
Copy link
Contributor

Question. Is there any way to temporarily remove all types of cache?

@laarmen
Copy link
Contributor

laarmen commented Nov 24, 2016

OK, apparently @jaj22 fixed it in #3876 , so closing.

@laarmen laarmen closed this as completed Nov 24, 2016
@impaktor
Copy link
Member

@walterar if this really is the same bug as #3345, as you say, then you can close that one now.

@walterar
Copy link
Contributor

@impaktor The appearance of bug #3345 is very previous to what gave rise to this error that solved jaj22. Luckily I was wrong to relate them. But unfortunately there must be something else wrong out there.

@jaj22
Copy link
Contributor

jaj22 commented Nov 24, 2016

@walterar Well, load/save and even load/load are generally high-stress and liable to trigger bugs in both C & lua code. I'm particularly interested in any cases where loading the same saved game multiple times generates different results. I suspect there's an arbitrary overwrite bug somewhere, but they're very difficult to identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants