Don't hard code when combat rank changes in stats tracking module #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dammit! I misread how |
impaktor
force-pushed
the
fix_combatrating
branch
from
bda9ba0
to
d8e4a0d
Compare
No, I'm an idiot. Fix was way simpler. Good for testing now. |
impaktor
force-pushed
the
fix_combatrating
branch
from
d8e4a0d
to
62cad6a
Compare
...instead use the methods in Character to determine when rank (e.g. 'HARMLESS' etc.) changes. Fixes pioneerspacesim#4162
impaktor
force-pushed
the
fix_combatrating
branch
from
62cad6a
to
db41e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead use the methods in Character to determine when rank (e.g. 'HARMLESS' etc.) changes.
Fixes #4162
100% untested, so need to verify there are no typos and works.