sectorview zoomout prettier homeworld labels #4245
Conversation
no more quick and dirty labels. made the point stand out from the background clutter with contrast background. centered the label and decreased the margins slightly. label no longer overlaps the star.
|
|
| va.Add(vector3f(pos.x + labelWidth + 5.f, pos.y - 5.f + labelHeight, 0)); | ||
| m_material->diffuse = labelBorder; | ||
| m_renderer->DrawTriangles(&va, renderState, m_material.Get(), Graphics::TRIANGLE_STRIP); | ||
| } |
There was a problem hiding this comment.
You removed the explicit code blocks, any reason?
There was a problem hiding this comment.
any reason for the codeblocks being there in the first place? other than not having to rename the variable?
I dont know if the compiler optimizes away locally created stack frames, but if it doesnt, then thats overhead just for being too lazy to rename a variable.
There was a problem hiding this comment.
-
If the code-snippet is repeated, with just variable name change, then why not a nice lambda-function?
-
putting actual feature change/addiont in seperate commit, and then all refactoring changes in a single commit e.g. names "refactoring changes" or "indentation fix" or something, makes it easier to review.
There was a problem hiding this comment.
Dude... I dont know C++.. but I do know that the new code is in 3 blocks that replace the previous two blocks. none of the three new blocks is identical, they all have some differences. none of the change is "indentation fix".
|
This is good, I've only got time a quick skim, hopefully merge it tomorrow |
no more quick and dirty labels. made the point stand out from the background clutter with contrast background. centered the label and decreased the margins slightly. label no longer overlaps the star.