Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny docking requests too far from station #4371

Closed
wants to merge 1 commit into from
Closed

Deny docking requests too far from station #4371

wants to merge 1 commit into from

Conversation

WKFO
Copy link
Contributor

@WKFO WKFO commented Jul 6, 2018

I thought reserving a docking port from 11AU was insane and space stations' air traffic controllers shouldn't grant such clearances. If I were them, I wouldn't. Would you? (I would be suprised if someone requested clearance from 500.000km away and made it in time.) I might just need a more proper excuse to deny those requests, though (current message is a placeholder). Come up with a good excuse and I will change the message :)

'Too far' as in 'more than 100km'. Which is a long enough braking/slow-travelling distance in my opinion.

@WKFO
Copy link
Contributor Author

WKFO commented Jul 6, 2018

WHOA! Conflict?

@fluffyfreak
Copy link
Contributor

@WKFO Nothing to worry about, just that the language files got updated.

@WKFO
Copy link
Contributor Author

WKFO commented Jul 6, 2018

Okay, it was just unexpected.

@bszlrd
Copy link
Contributor

bszlrd commented Jul 6, 2018

@WKFO: does the 'Dock with" autopilot knows about it?

@WKFO
Copy link
Contributor Author

WKFO commented Jul 6, 2018

'Dock with' autopilot doesn't know about it on the code side but it requests for docking at 15km distance.
Tested it tens of times, had no problem so far.

@bszlrd
Copy link
Contributor

bszlrd commented Jul 6, 2018

Cool.

@richardpl
Copy link
Contributor

This can not be merged as branch have conflicts.

@WKFO
Copy link
Contributor Author

WKFO commented Jul 9, 2018

Okay, will try to fix.

@WKFO
Copy link
Contributor Author

WKFO commented Jul 9, 2018

I don't know what I just did but it showed like the entire file was replaced. Reverting...

@richardpl
Copy link
Contributor

Merged.

@richardpl richardpl closed this Jul 9, 2018
@WKFO WKFO deleted the clearance branch July 9, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants