Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stepped and scaled wind rushing sounds. #2365

Closed
wants to merge 5 commits into from

Conversation

fluffyfreak
Copy link
Contributor

Thanks to "Staniol" we've got some stepped and scaled ferocity to the wind rushing sounds.

Very effective if entering an atmosphere a bit... energetically.

The final values I've chosen might take some tweaking but as I have it now you are VERY aware of when you've come in too fast! However it also doesn't deafen you when you're just cruising along through the atmosphere.

Also added new sounds for cockpit crew but these haven't yet been hooked up to anything.

First attempt at stepped implementation.
Update shield hit sound.
Tried to tidy the AmbientSounds.cpp a little bit. Move some things out to static const arrays and suchlike.
@laarmen
Copy link
Contributor

laarmen commented Jul 8, 2013

Would it be possible for Staniol to also give us some lossless version
(.wav, .flac) in case we ever need to modify the sounds later?

Fluffy, thanks for all the work \o/

@fluffyfreak
Copy link
Contributor Author

Dunno, might be a good idea to ask him.

Which I just have :)

@robn
Copy link
Member

robn commented Jul 9, 2013

It can be resolved with some careful diffing work. Get the file @49d775a, convert it to CRLF, take a diff between the working copy and @ccb82e5, convert the diff back to LF, then apply that patch. Something like that.

I can try it on my trip in to work tomorrow if you need help. Just let me know.

@fluffyfreak
Copy link
Contributor Author

I should have just committed the line endings in a separate PR.
The changes aren't major anyway, they're mostly renaming to match the code guidelines, moving some arrays to be static const global, and then the work itself which was quite minor.

@fluffyfreak
Copy link
Contributor Author

Oh yes, as a way to test, just try plowing into the atmosphere of Venus at high speed :)
it'll scream at you for while then die down as your speed drops off. Very much a howling roaring effect at the high-speed end and normal wind rush at the low-speed / density end.

@shadmar
Copy link
Contributor

shadmar commented Jul 11, 2013

Just tested on Venus, cool effect :)

@Luomu
Copy link
Member

Luomu commented Jul 12, 2013

Merged

@Luomu Luomu closed this Jul 12, 2013
@fluffyfreak fluffyfreak deleted the GotWind branch July 12, 2013 08:12
Zordey pushed a commit to Zordey/pioneer that referenced this pull request Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants