Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable/disable background (skybox+stars) rendering #2813

Closed
wants to merge 2 commits into from

Conversation

robn
Copy link
Member

@robn robn commented Mar 17, 2014

Some people like that sort of thing.

@fluffyfreak
Copy link
Contributor

Code looks ok to me after a quick look, feature seems like a step back to me but oh well :/

@robn
Copy link
Member Author

robn commented Mar 17, 2014

I'm happy to withdraw it. Personally I abhor config options. I'm of the opinion that it shouldn't be possible to configure in-game elements. Fair enough for stuff like video cards, languages, etc - stuff that affects the player or the hardware. But for stuff in-game no; I want one consistent experience.

Maybe I shouldn't have bothered at all. I usually push back when someone says "how about a config option?". Call it a moment of weakness, its been a long couple of weeks.

I guess I'd take most of @7f880ac either way, because I think its better structurally.

Yeah bollocks to it. Closing, will just do the cleanup. Tomorrow maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants