Cppcheck changes #3384
Merged
Cppcheck changes #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efix not postfix operator etc.
|
Spring cleaning, yay! |
…en the appropriate value changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran CppCheck against the current master and came up with a few easy changes. Removal of a little dead code, some cleanup for 'operator=' and '++/--' prefix vs postfix operators etc.
The biggest, most numerous, changes are in 'fixed.h' which was passing a lot of things by value instead of by reference.
I don't think anything will have much impact so this is more an attempt to get the number of messages reported by CppCheck reduced.