Added search field to bulletin board tab

[ColdSpirit0]

Bulletin board splitted to 2 columns. I wanted to make a floating search field, but dont know how: documentation does not have references to ui elements. And there no ui examples too.

[nozmajner]

Good idea, but note that we want to get rid of this UI system eventually. Won't happen overnight though.

[fluffyfreak]

Nice

[ColdSpirit0]

get rid of this UI system

You mean Lua UI? If so, it sad. Modding without UI system support feels imperfect.

[nozmajner]

@ ColdSpirit0: no, that specific UI system that is used for the station and infoview stuff. We want to move all UI to imgui which would allow more modding possibilities. See the new HUD and #4078

[ColdSpirit0]

@nozmajner
Im watching UI code and trying to uderstand architecture. Now UI hardly bounded with C++ methods like Game::SetView(), but after update View classes with full "data/ui" directory will no longer be needed and new UI fully will be on lua-imgui engine in the directory "pigui". I think right?

Have some questions about modules:
Is "game.lua" will be splitted to modules in the future? There many ui code.

As I see "fx-window.lua" contains buttons on top of screen. Why file named so (I mean "fx" part)? =)) Maybe better to rename it to something more intuitive?

Which architecture is better?

• "fx-window.lua" have space on top of the screen and it can register buttons and assigned windows, and calls it when need. Has single style for all windows and buttons. For button order have weight (or maybe something better?).
• each view modue creates own button in own window as fully independent module of "game.lua".

My choice is first, because there many similar logic in view creation.

Upd:
Will be Lua code documented with LuaDoc or similiar?

[nozmajner]

@ColdSpirit0
Yes, that's the plan, to move everything to imgui. But sadly that's all I'm able to answer from your questions, since I'm not on the code side of things. Ecraven will be able to help you when he gets back.

[impaktor]

new UI fully will be on lua-imgui engine in the directory "pigui". I think right?

Yes, that's my understanding.

Will be Lua code documented with LuaDoc or similiar?

We have the LuaAPI, that you can build using naturaldoc (see COMPILING.txt file).
Ideally, things should be documented there, although UI hasn't been so far.

[nozmajner]

Anyhow, I really like this, I think it could be merged, with the caveat of it will eventually go away/ported to imgui when we get to this part.

[ColdSpirit0]

I working on new views system on imgui now, you can to watch it in my fork in "develop" branch.
For players entertainment you can to add this to next build if new system with imgui views will be not done.

[impaktor]

I working on new views system on imgui now,

Great you're getting to know the new system! That will not be in vain. However, I'm worried you and ecraven will start stepping on each others toes. I'm sure he'd be happy with help on moving to imgui, but I suspect he/we will re-write code if it's not "nice" enough or "done in the right way", just so you're prepared for that. (some contributors get offended when their code gets removed/re-written in master).

I think he'll be back later this week, so you could coordinate with him, moving various things to imgui, and possibly open a WIP PR, that he/we can review and give continous feedback on, so code goes in the right direction.

I don't know your code skill level, but assuming you want to help moving us to imgui, you and ecraven could work on different ends of it. E.g. main menu or galaxy view should just be moved pretty much as they are, to imgui, while I suspect he will soon start working on the F2 screens. But I don't know, just some ideas I'm spitting out.

[impaktor]

Also, please let us know (here, or on IRC) if you want to be in AUTHORS.txt

[fluffyfreak]

@ColdSpirit0 thanks for the helpful first PR!

[ColdSpirit0]

@impaktor

some contributors get offended

Experience is above all =)
It my first project where I interact with git so much, and already got much experience.

I'm worried you and ecraven will start stepping on each others toes

As I see, he is working on HUD and similar, because much code written for it. But with view system interacts only one file - fx-window.lua, that draws new buttons and calls old views, and I want replace it with new system. I think we go in parallel.
But dont know how things are in his repo. I hope for 2 days I will finish base view system and then we will be able to continue work freely. WIP PR sounds good.

My code skill not too good (a bit of everything) but move old ui to new is not so hard, I think.

@fluffyfreak glad to help!

[impaktor]

Sounds good, but just be aware that the UI design is done in close collaboration with @nozmajner who does mock-ups and designs / suggests how the end product should look. This will give us a coherent, and good UI. See #4078 and links there in.

[ColdSpirit0]

@impaktor thanks for the pointing.