Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LowThrust Setting to ImGui #4261

Merged
merged 1 commit into from Jan 12, 2018

Conversation

The-EG
Copy link
Contributor

@The-EG The-EG commented Jan 7, 2018

Clicking on the low thrust indicator or pressing F8 now shows the slider
above the low thrust indicator. The slider can be used to adjust the
amount of thrust when 'low thrust' is active. Clicking the low thrust
indicator or pressing F8 again hides the slider.

base profile screenshot 2018 01 07 - 13 34 49 100

@impaktor
Copy link
Member

impaktor commented Jan 7, 2018

Sweet!

Skimming the code, I assumed there would be more deletions? The old C++ side menu that was shown aught to be nuked, no? (Note: I'm just assuming, haven't really looked.)

@The-EG
Copy link
Contributor Author

The-EG commented Jan 7, 2018

@impaktor I didn't delete the c++ side, I'll look at that.

@The-EG
Copy link
Contributor Author

The-EG commented Jan 8, 2018

@impaktor C++ stuff should now be removed as well.

Clicking on the low thrust indicator or pressing F8 now shows the slider
above the low thrust indicator. The slider can be used to adjust the
amount of thrust when 'low thrust' is active. Clicking the low thrust
indicator or pressing F8 again hides the slider.
@fluffyfreak
Copy link
Contributor

This is ready to merge?

@fluffyfreak fluffyfreak merged commit b331bf3 into pioneerspacesim:master Jan 12, 2018
@The-EG The-EG deleted the imgui-thrusterslider branch January 13, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants