Properly translate and localize the bindings options view. #4568
Conversation
data/lang/input-core/en.json
Outdated
| "message": "Reset Camera View to Default", | ||
| "description": "Descriptive name for the ResetCamera action." | ||
| }, | ||
|
|
There was a problem hiding this comment.
Normally (as in all other files), we have description field before message field. I think @ecraven added something that will auto-format this when merged (confirm?), so no action should be needed, I think.
|
Nice! Just a reminder to myself (or anyone else merging), I/we need to do some transifex magic to the new language resource, as usual. |
|
merge tomorrow? |
|
Sounds good to me. I'm working on some control changes out of this branch, but they're mostly unrelated. I can delete unused/unneeded keys from a resource without things breaking horribly, right? |
Yes |
|
Sorry for not getting around to this, but you can still make a new branch of this branch, and once this is merged, you can git cherry-pick the additional commits to a new PR. |
|
The reason I haven't merged this, is I'd like to know/remember how our json autoformater works. Not sure where that lives now, but I remember we have/had one? ping @ecraven |
(+ run jq . < en.json for formating)
impaktor
force-pushed
the
input-improvements
branch
from
8429167
to
5cbec9b
Compare
|
I did an Sorry for this taking so long, but took some time to get hold of ecraven for figuring out formating of the json file. Hope this hasn't stalled your tinkering with pioneer. |
(Finally!) added localization support to the new input system.