Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly translate and localize the bindings options view. #4568

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@Web-eWorks
Copy link
Contributor

commented Apr 1, 2019

(Finally!) added localization support to the new input system.

"message": "Reset Camera View to Default",
"description": "Descriptive name for the ResetCamera action."
},

This comment has been minimized.

Copy link
@impaktor

impaktor Apr 2, 2019

Member

Normally (as in all other files), we have description field before message field. I think @ecraven added something that will auto-format this when merged (confirm?), so no action should be needed, I think.

@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Nice!

Just a reminder to myself (or anyone else merging), I/we need to do some transifex magic to the new language resource, as usual.

@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

merge tomorrow?

@Web-eWorks

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Sounds good to me. I'm working on some control changes out of this branch, but they're mostly unrelated.

I can delete unused/unneeded keys from a resource without things breaking horribly, right?

@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

I can delete unused/unneeded keys from a resource without things breaking horribly, right?

Yes

@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Sorry for not getting around to this, but you can still make a new branch of this branch, and once this is merged, you can git cherry-pick the additional commits to a new PR.

@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

The reason I haven't merged this, is I'd like to know/remember how our json autoformater works. Not sure where that lives now, but I remember we have/had one? ping @ecraven

Properly translate and localize the bindings options view.
(+ run jq . < en.json for formating)

@impaktor impaktor force-pushed the Web-eWorks:input-improvements branch from 8429167 to 5cbec9b Apr 16, 2019

@impaktor impaktor merged commit 5cbec9b into pioneerspacesim:master Apr 16, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@impaktor

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I did an amend on your initial commit (jq formating of the json file), and pushed it back to this branch, if you wonder why commit hash / your branch has changed.

Sorry for this taking so long, but took some time to get hold of ecraven for figuring out formating of the json file. Hope this hasn't stalled your tinkering with pioneer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.