Fixing issue #5550 where empty accessory files makes manual handling erratic #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
changed the title
Web-eWorks
approved these changes
Feb 21, 2023
Gliese852
reviewed
Feb 21, 2023
| @@ -36,7 +36,7 @@ local function rerollFaceDesc(oldDesc) | |||
| FEATURE_NOSE = Engine.rand:Integer() % 2^31, | |||
| FEATURE_MOUTH = Engine.rand:Integer() % 2^31, | |||
| FEATURE_HAIRSTYLE = Engine.rand:Integer() % 2^31, | |||
| FEATURE_ACCESSORIES = Engine.rand:Integer() % 2^31, | |||
| FEATURE_ACCESSORIES = Engine.rand:Integer() % 4 == 0 and Engine.rand:Integer() % 2^31 or 0, -- accessory on one out of four faces | |||
There was a problem hiding this comment.
I guess the and branch can also generate an empty accessory?
There was a problem hiding this comment.
Correct. With the current number of accessories every eighth png will be invisible.
|
Did we used to have santa hat for our faces, when computer clock is Christmas, or was it Frontier, or did I dream that? |
I just experimented with a santa hat and also a hijab to test the layers of facegen. Are any of those actually in this PR?! I can't find them in here. |
|
Looks good, thanks @zonkmachine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5550
Here is a fix for #5550.
The Character faces now have an accessory generated about one time in four. Player character, bbs faces or random button in the face app in the 'Personal Information' window all works. When you step the accessories in the face app they will show up all about the 1st step which is an empty file that was kept so you can intentionally select 'no accessory'.