Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main menu music not starting to play after exiting back to main menu #5645

Conversation

Max5377
Copy link
Contributor

@Max5377 Max5377 commented Oct 10, 2023

Fix for when menu music not started to play after exiting back to main menu.

Update: moved MusicPlayer.playRandomSongFromCategory("menu", true) from if else check.

Fix for when menu music not started to play after exiting back to main menu.
@Max5377 Max5377 force-pushed the main-menu-music-not-playing-after-exiting-to-main-menu branch from afe9af7 to 5af7c48 Compare October 11, 2023 19:43
@impaktor
Copy link
Member

@WKFO thoughts?

@WKFO
Copy link
Contributor

WKFO commented Oct 13, 2023

Looks good to me.

@Web-eWorks Web-eWorks merged commit f3b8b55 into pioneerspacesim:master Oct 14, 2023
@Max5377 Max5377 deleted the main-menu-music-not-playing-after-exiting-to-main-menu branch October 15, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants