Fix undefined behaviour in CommandBufferGL.cpp #5694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By compiling with sanitisers enabled I have detected a number of places where we run into undefined behaviour. The patch for the first is in #5692 (thanks to Web-eWorks). This is a patch for the second issue I detected.
mat->m_pushConstants.get()
is sometimes null.s->GetConstantStorageSize() == 0
Fix: add a null check.
Here is how I compile with sanitisers.
1 Make sure
build/
does not exist (because cmake does not update CXXFLAGS for build directories that have already been populated). Alternatively: build inbuild-with-sanitizers/
2.
CXXFLAGS="-fsanitize=address,pointer-compare,pointer-subtract,undefined" LDFLAGS="$CXXFLAGS" cmake -S . -B build/ && make -j2 -C build/