Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microfixes #5729

Merged
merged 8 commits into from Feb 2, 2024
Merged

Microfixes #5729

merged 8 commits into from Feb 2, 2024

Conversation

Web-eWorks
Copy link
Member

@Web-eWorks Web-eWorks commented Jan 30, 2024

Catch-all bugfix PR, part of my annual microfixes series.

Potentially more fixes to come before merge...

- Resolves issues with VS2019 not being able to parse the CMakePresets.json file
- Requires one additional package to be installed, which has been documented in COMPILING.txt
- Return coordinates relative to the surface of the body being orbited, rather than the frame the body is in
- Fixes an issue where GPS coordinates change when leaving the rotating frame of a body
- EditorApp inadvertently deleted the IniConfig object the Input subsystem holds a reference to.
- To avoid dangling pointers to the stack, store the editor config object in the EditorApp itself.
- Update to actions/checkout@v4; v3 is soft-deprecated due to node16 dependency
- V4 provides potentially significantly faster artifact uploads and customizable compression levels for the artifact zip file.
- Annotate CI builds with information about the PR or branch which triggered the build
@Web-eWorks
Copy link
Member Author

Merging as good enough, Windows builds of the release will display refs/tags/20240203 as the version info in addition to the commit hash.

@Web-eWorks Web-eWorks merged commit a367e23 into pioneerspacesim:master Feb 2, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants