Update Github Upload-Artifact action for Windows CI #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inadvertently got missed during the last set of CI updates - this PR updates the Windows
upload-artifactGithub Action to use version 4 of that action, which is more efficient and provides much faster upload speeds (and also addresses the deprecation notice from using v3).This also normalizes the Windows artifacts to be retained for 14 days after a build - given that we're generating >1GB of artifacts from each build and there's little need to download a pre-built archive of a past build, it doesn't really make sense to retain builds for the default of 90 days. Binaries uploaded to Github Releases are not affected by this change - they're stored separately and will be retained permanently (for as long as the release exists).