System Editor Fixes #5787
Merged
System Editor Fixes #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Web-eWorks
commented
Mar 1, 2024
Web-eWorks
commented
- Fix the tab key not working to confirm certain fields in the system editor (the changed value wasn't being written back to the datastructure unless the enter key was pressed). Fixes System editor issues - bodies not showing, file extension missing, etc #5746.
- The initial state of the system editor didn't display edit fields for a body's population and agricultural index, as they're overwritten by random values when the system is loaded. Those fields are now shown but left disabled with a notice until the fields are honored by the system loading code.
- Passing the input flag EnterReturnsTrue prevented the changed value from being written back unless the enter key was pressed to confirm the change - Rely on the undo system instead to handle intermediate edits of the value
- These properties are currently overwritten when loading custom systems - Display a disabled edit field with a TODO notice until that changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.