Fix loud white nosie after mouse steering #5812
Conversation
…unds and inability to turn)
|
I can confirm, it fixes the problem. Thank you! |
|
@Web-eWorks Do you want to review code before merge? |
|
Yes, will give this a review in the next few days. I've been very busy recently and sadly haven't gotten a chance to review any of the new PRs yet. |
| @@ -67,6 +67,11 @@ DynamicBody::DynamicBody(const Json &jsonObj, Space *space) : | |||
| throw SavedGameCorruptException(); | |||
| } | |||
|
|
|||
| // fix saves with nans | |||
There was a problem hiding this comment.
I'd recommend this comment be annotated with the current savefile version (see Game.cpp) so that the workaround can be removed when the next savebump occurs.
There was a problem hiding this comment.
I think we used to add "todo" notes to SAVEBUMP.txt as well, things to fix for next release, so that might be a good idea.
I should add "checking SAVEBUMP.txt" to the release guide, if we think this is a good strategy?
There was a problem hiding this comment.
That would be a good idea on both counts; this definitely deserves to be in the SAVEBUMP.txt file as well.
|
Other than the requested change, the code looks good - thanks for the fix! |
|
I've pushed the required documentation changes to this PR's branch - thanks for the contribution! |
Fix #5804