-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a file header comment #18
Add a file header comment #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for making it easy to review :) It's much better this way!
I left a few small comments, should be easy to fix. When it's done, we're good to go :)
@piotr-oles I'm working on another PR which will add helper methods for encoding and decoding. Do we want that as a default behavior too or should I add a compiler option for it? |
For this one please add an option :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good :)
🚀 PR was released in |
@piotr-oles As suggested in this comment, together with @Seb-figment we're splitting the code from #10 into 3 separate pull requests:
Please let us know if this works for you.