Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file header comment #18

Merged
merged 7 commits into from
Aug 10, 2022

Conversation

pienkowb
Copy link
Contributor

@pienkowb pienkowb commented Aug 9, 2022

@piotr-oles As suggested in this comment, together with @Seb-figment we're splitting the code from #10 into 3 separate pull requests:

Please let us know if this works for you.

Copy link
Owner

@piotr-oles piotr-oles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making it easy to review :) It's much better this way!
I left a few small comments, should be easy to fix. When it's done, we're good to go :)

README.md Outdated Show resolved Hide resolved
packages/as-proto-gen/src/generate/header.ts Outdated Show resolved Hide resolved
packages/as-proto-gen/src/generate/header.ts Outdated Show resolved Hide resolved
@pienkowb
Copy link
Contributor Author

@piotr-oles I'm working on another PR which will add helper methods for encoding and decoding. Do we want that as a default behavior too or should I add a compiler option for it?

@piotr-oles
Copy link
Owner

For this one please add an option :)

Copy link
Owner

@piotr-oles piotr-oles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good :)

@piotr-oles piotr-oles added the patch Increment the patch version when merged label Aug 10, 2022
@piotr-oles piotr-oles merged commit 7ea2392 into piotr-oles:main Aug 10, 2022
@github-actions
Copy link

🚀 PR was released in v0.2.6 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 10, 2022
@pienkowb pienkowb deleted the file-header-comment branch August 11, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants