Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network roundtrip on each serialised message #2

Open
piotr-yuxuan opened this issue Mar 30, 2021 · 0 comments
Open

Network roundtrip on each serialised message #2

piotr-yuxuan opened this issue Mar 30, 2021 · 0 comments
Assignees
@piotr-yuxuan
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0.0

Comments

@piotr-yuxuan
Copy link
Owner

piotr-yuxuan commented Mar 30, 2021 •
edited

slava/src/piotr_yuxuan/slava.clj

Lines 28 to 32 in 234a755

(defn schema-id!
"FIXME add cljdoc"
;; FIXME on every serialization. Should be cached.
[^SchemaRegistryClient inner-client ^String subject-name]
(.getId (.getLatestSchemaMetadata inner-client subject-name)))

It can be avoided by using metadata, but it shouldn't happen in the general case.
@piotr-yuxuan piotr-yuxuan added the bug Something isn't working label Mar 30, 2021
@piotr-yuxuan piotr-yuxuan added this to the 1.0.0 milestone Mar 30, 2021
@piotr-yuxuan piotr-yuxuan self-assigned this Mar 30, 2021
piotr-yuxuan added a commit that referenced this issue Apr 10, 2021
@piotr-yuxuan
WIP
36d68f1 
#2
piotr-yuxuan added a commit that referenced this issue Apr 17, 2021
@piotr-yuxuan
WIP
ff6fd53 
#2
@piotr-yuxuan piotr-yuxuan added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotr-yuxuan piotr-yuxuan

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@piotr-yuxuan