Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not need character is append in Basic Auth Header #334

Merged
merged 1 commit into from
Nov 17, 2017
+1 −1
Merged

Fix not need character is append in Basic Auth Header #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github_api/request/basic_auth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def initialize(app, *args)
# @api private
def call(env)
if @auth
env[:request_headers].merge!('Authorization' => "Basic #{@auth}\"")
env[:request_headers].merge!('Authorization' => "Basic #{@auth}")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use env[:request_headers]['Authorization'] = "Basic #{@auth}" instead of env[:request_headers].merge!('Authorization' => "Basic #{@auth}").
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

end

@app.call(env)
Expand Down