Reduce gem dependencies to railties
#45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Currently the gem depends on the entirety of
rails
, which adds some"dependency weight" to projects that only need a subset of Rails
functionality. This changes the gem to depend on
railties
instead,which covers all of the core Rails functionality Loaf needs to function.
Why are we doing this?
Fixes issue #44
Benefits
Installing Loaf will no longer lead to additional Rails sub-gems being installed beyond what Loaf needs to function (e.g.
actioncable
,active storage
etc.) beyond what the host application requires.Drawbacks
Requirements
Put an X between brackets on each line if you have done the item:
[x] Tests written & passing locally?
[x] Code style checked?
[x] Rebased with
master
branch?[x] Documentaion updated?