Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Fix Cursor #save in AppVeyor testing #6

Merged
merged 1 commit into from Aug 1, 2017

Conversation

austb
Copy link
Contributor

@austb austb commented Aug 1, 2017

No description provided.

@piotrmurach piotrmurach merged commit 170dbbc into piotrmurach:master Aug 1, 2017
@austb
Copy link
Contributor Author

austb commented Aug 1, 2017

Unfortunately, it looks like AppVeyor w/ Ruby 1.9.3 is failing because of Gem dependencies

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cecf583 on austb:fix_appveyor into f60a1f1 on piotrmurach:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cecf583 on austb:fix_appveyor into f60a1f1 on piotrmurach:master.

@piotrmurach
Copy link
Owner

That's fine, it is expected in the test matrix.

@piotrmurach
Copy link
Owner

I was kind of thinking about the win_platform check. The danger here is with cygwin emulators and such, which should be compatible with major terminals. In any case, I'm happy to release. Btw I've tried this version with tty-spinner using save & restore in write and it seems to work fine.

@piotrmurach
Copy link
Owner

Do you have anything else to add before release?

@austb
Copy link
Contributor Author

austb commented Aug 1, 2017

Nope, I'll go switch my TTY::Spinner PR back to using #save and #restore. Thanks!

@piotrmurach
Copy link
Owner

Released v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants