move handling of event to prevent thread crash #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmurach
added a commit
that referenced
this pull request
Feb 27, 2016
move handling of event to prevent thread crash
|
Thanks for looking into this! The resizing callback is for situation where you set your expected width in terms of terminal columns, let's say 100, and then attempt to resize the window to 60 columns. The result should be that the actual progress bar recalculates the ratio and scales the whole thing down without breaking. |
piotrmurach
added a commit
that referenced
this pull request
Feb 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the thread crash but the original code didn't seem to actually resize the window. While (manually) testing, I took out the callbacks and saw no visible change but I'm probably just not understanding what it's doing.
So, this seems to work the same but I'm not 100% on the actual resizing callback.
The exit would crash the same and this seems to fix that (ctrl-c).