Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #37 #41

Merged
merged 1 commit into from Jul 11, 2020
Merged

Fix #37 #41

merged 1 commit into from Jul 11, 2020

Conversation

d4be4st
Copy link
Contributor

@d4be4st d4be4st commented Mar 8, 2020

Describe the change

Fixes #37
Adds a public method to reset @done and @stopped.

Why are we doing this?

On multi bars if we are adding new bars dynamically, the top bar is going to finished (@done? will return true) after the first registered bar is done.
register method increases the total of @top_bar but @done remains set to true and that why it does not render anymore even though we add new bars.

Benefits

Fixes multiple bars with dynamically registered bars.

Drawbacks

Shouldn't be any

Requirements

Put an X between brackets on each line if you have done the item:
[x] Tests written & passing locally?
[x] Code style checked?
[x] Rebased with master branch?
[x] Documentaion updated?

@coveralls
Copy link

coveralls commented Mar 8, 2020

Coverage Status

Coverage increased (+0.005%) to 99.328% when pulling 80f7e6e on d4be4st:master into 5491328 on piotrmurach:master.

@piotrmurach piotrmurach merged commit 7f795f1 into piotrmurach:master Jul 11, 2020
@piotrmurach
Copy link
Owner

Thank you! ❤️ I may rename the method but the overall solution feels right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi progress bar does not update drawing current / total values properly
3 participants