-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md lies about #no? behavior #11
Comments
Hi Dmitrii, the code is broken, there's already pull request submitted that fixes it. I will merge shortly. |
This is implemented in master, if you've got a minute to spare to try it out that would be sweet. The readme explains how to customize the |
@peter-murach I like the new version, though it still has some issues. For example:
I think is should allow me to decide what answer should be the default because it is often a question of formulation: whether to use #yes? or #no? Also it seems that I'll need do define all 4 options in order to have a customized question. I understand that it is a trade-off for a current flexibility, yet it feels a little annoying. Nevertheless, it is now much better than before. Thanks for your work, I like this gem very much) |
Totally agree, the default is actually meant to change the answer. I suppose 4 options feels clunky, I'm trying to reuse functionality built in such as conversion function. I'm happy to consider different approach, do you have any examples I could take a look at? This is not released yet so we can tweak functionality until it's awesome. |
@vizvamitra I've fixed the bug and changed the behaviour to allow you to specify only |
@vizvamitra I've released |
README.md states:
What really happends:
Also I've failed to find a way to make
.ask(..., convert: :bool)
to show (y/N), so perhaps it is an issue with it (or with README.md)The text was updated successfully, but these errors were encountered: