Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of certain prompts #12

Closed
jcampbell05 opened this issue Mar 25, 2016 · 6 comments
Closed

Change color of certain prompts #12

jcampbell05 opened this issue Mar 25, 2016 · 6 comments

Comments

@jcampbell05
Copy link

I would like to change the color of certain prompts such as the default value prompt and the "use arrow keys to move up and down"

They end up being black which blends in with black terminals.

@piotrmurach
Copy link
Owner

Sure thing, would you mind listing exactly which prompts and what you need changing? For example, for select and multi_select prompts you can change help text by passing :help see I would be interested to see screenshot of the prompt you are making? Also, if you could provide example(s) of how you envisage the code working I'm happy to change things.

@jcampbell05
Copy link
Author

screen shot 2016-03-25 at 14 16 10

screen shot 2016-03-25 at 14 16 15

See above that the default is printed as black so it isn't shown unless highlighted in dark terminals. (Same for the prompt for multi_select )

screen shot 2016-03-25 at 14 18 12

screen shot 2016-03-25 at 14 18 21

Also if a default value is provided but its empty i.e "" or nil, then a "()" is still printed.

@piotrmurach
Copy link
Owner

Cheers, that really helps! I use black background terminals, i.e. on Debian and the help is visible(it's grayish). I will probably change the default colour to one with more contrast and also allow for setting one for the whole prompt business. For the moment you should be able to pass in :help option with coloured string?

Thanks for spotting the bug, will fix! This is all good stuff, please keep on reporting, PRs are welcome as well.

@jcampbell05
Copy link
Author

@piotrmurach Sure! Yeah being able to theme will be a big help. Will try to do some PRs to help :)

@piotrmurach
Copy link
Owner

Hi @jcampbell05, just released v0.5.0 that fixes these issues and allows you to change color settings to your hearts content, please read. Hope you like it.

@jcampbell05
Copy link
Author

That is great many thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants