Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for menu choices #149

Merged

Conversation

caalberts
Copy link
Contributor

Describe the change

What does this Pull Request do?

  • Add examples for menu choices

Why are we doing this?

Any related context as to why is this is a desirable change.

  • Most of the example code are followed by the output illustrating how the prompt would look like to the user. Having the examples for the first code example in menu choices would help to a potential user imagine the interaction.

Benefits

How will the library improve?

  • It would be easier to use with more examples.

Drawbacks

Possible drawbacks applying this change.

  • none

Requirements

Put an X between brackets on each line if you have done the item:
[] Tests written & passing locally?
[] Code style checked?
[x] Rebased with master branch?
[x] Documentation updated?

@caalberts
Copy link
Contributor Author

@piotrmurach What do you think of this change?

@coveralls
Copy link

coveralls commented Sep 5, 2020

Coverage Status

Coverage increased (+0.005%) to 97.571% when pulling 31ba72c on caalberts:caalberts-add-menu-choices-examples into f79196e on piotrmurach:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 97.476% when pulling 31ba72c on caalberts:caalberts-add-menu-choices-examples into f79196e on piotrmurach:master.

@piotrmurach piotrmurach merged commit dbae90b into piotrmurach:master Sep 5, 2020
@piotrmurach
Copy link
Owner

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants