Change to restore hidden cursor when auto spinning fails in ref issue #…

…34
piotrmurach · Nov 27, 2018 · 99ff64a · 99ff64a
1 parent 51b2d5b
commit 99ff64a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/tty/spinner.rb b/lib/tty/spinner.rb
@@ -247,6 +247,10 @@ def auto_spin
           end
         end
       end
+    ensure
+      if @hide_cursor
+        write(TTY::Cursor.show, false)
+      end
     end
 
     # Checked if current spinner is paused

diff --git a/spec/unit/auto_spin_spec.rb b/spec/unit/auto_spin_spec.rb
@@ -13,4 +13,15 @@
 
     expect(spinner).to have_received(:spin).at_least(5).times
   end
+
+  it "restores cursor when erorr is raised" do
+    spinner = TTY::Spinner.new(output: output, hide_cursor: true)
+
+    spinner.auto_spin {
+      raise 'boom'
+    }
+
+    output.rewind
+    expect(output.read).to start_with("\e[?25l").and end_with("\e[?25h")
+  end
 end