Why instance_eval?

[tyler-ball]

I needed to do something like this with the multi-spinner:

class MyClass

  attr_reader :config

  def doit
    ...
    spinners.register("[:spinner] :title") do |spinner|
      spinner.update(title: "#{config.value}")
    ...
  end
end

I wasn't sure why the job block was being instance_evaled. Is there a specific reason instead of just calling it?

[coveralls]

Coverage decreased (-0.3%) to 94.464% when pulling 92248f1 on tyler-ball:master into 5aa42df on piotrmurach:master.

[coveralls]

Coverage decreased (-0.3%) to 94.464% when pulling 92248f1 on tyler-ball:master into 5aa42df on piotrmurach:master.

[piotrmurach]

I found it to be more flexible and intuitive as you can do the following with your example:

def doit
    ...
    spinners.register("[:spinner] :title") do
      update(title: "#{config.value}")
    ...
end

[tyler-ball]

Ahh, the docs show the spinner being passed in as the first argument to the block, so thats how we structured our code. That gave us access to do spinner.update instead of just update.

LMK if you want me to continue this - I can look into the failing tests but I'm not sure why they are failing off the top of my head.

[piotrmurach]

I've added execute_job to detect the type of block you pass, so your scenario is included there. Does that work for you?

Please have a look into the multi examples. If you prefer to have more control over your multi spinner you don't have to register jobs but only the spinner format. You can later control each spinner manually. I will add some docs shortly. Unfortunately, I'm on tight schedule and have to release new version today.

[piotrmurach]

@tyler-ball I've added more docs that explain how to have full control over multi spinner registered spinners.

[tyler-ball]

Thanks @piotrmurach !

[piotrmurach]

@tyler-ball multi spinner stuff has been released as v0.5.0