Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't quite understand the section "Don't write to global functions" #96

Closed
panigrc opened this issue Sep 8, 2017 · 4 comments
Closed

Comments

@panigrc
Copy link

panigrc commented Sep 8, 2017

I don't understand how the

// config.php
return [
    'foo' => 'bar',
];

How is the array being used ?

link

@peter-gribanov
Copy link
Contributor

I agree. It doesn't look very clear.
The idea was this:

$config = include 'config.php';

$configuration = new Configuration($config);

@panigrc
Copy link
Author

panigrc commented Sep 8, 2017

Ok Thanks for clarifying that ! 👍

@peter-gribanov
Copy link
Contributor

@panigrc Please take a look, my PR #97.
This example became more clear?

@TomasVotruba
Copy link
Contributor

Resolved by #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants