Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to missing anchor in the guide #219

Closed
schrer opened this issue Apr 13, 2022 · 2 comments · Fixed by #220
Closed

Link to missing anchor in the guide #219

schrer opened this issue Apr 13, 2022 · 2 comments · Fixed by #220

Comments

@schrer
Copy link
Contributor

schrer commented Apr 13, 2022

Description

Under the topic "Goals", the link with display text "complementary libraries" points to an anchor in the readme that does not exist.

Steps to Reproduce

  1. In the README, go to the paragraph titled Goals
  2. Third bullet point contains a link with display text "complementary libraries", pointing to https://github.com/piotrwitek/react-redux-typescript-guide/blob/master/README.md#complementary-libraries. This anchor does not exist (anymore?), so nothing really happens on click, beside a URI change in the address bar.

Suggested solution

Looking at the history of the file and the context I assume, that the link should point to the paragraph following the "Goal" paragraph, so https://github.com/piotrwitek/react-redux-typescript-guide/blob/master/README.md#react-redux-typescript-ecosystem
If that is correct, I could create a commit making that change and open a PR, if it helps.

@piotrwitek
Copy link
Owner

Hey @schrer, you're correct, I would gladly accept a PR :)
Thanks!

@schrer
Copy link
Contributor Author

schrer commented Apr 13, 2022

Alright, PR is open.
Unfortunately the build did not pass, I left a comment on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants