Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle array of types in isOfType #86

Conversation

paszkowskiDamian
Copy link
Contributor

@paszkowskiDamian paszkowskiDamian commented Oct 11, 2018

It is PR implementing new API proposed in issue #85. API of isOfType has been extended to accept also an array of types as redux-observable operator ofType. It does not introduce any baking changes.

  • Rebase before creating a PR to keep commit history clean
  • Clear node_modules and reinstall all the dependencies: npm run reinstall
  • Run checker npm script: npm run check

Extra checklist:

  • Always add some description and refer to all the related issues using # tag

For bugfixes:

  • Add at least one unit test to cover the bug that have been fixed

For new feature:

  • Update API docs
  • Add examples to demonstrate new feature
  • Add type unit tests
  • Add runtime unit tests

@paszkowskiDamian paszkowskiDamian changed the title Handle array of types in is of type Handle array of types in isOfType Oct 11, 2018
@piotrwitek piotrwitek merged commit bfb298f into piotrwitek:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants